Skip to content

Commit 43718c3

Browse files
authoredApr 7, 2021
[WIP] Fix out_path argument and describe TOOLPATH pointing location (#135)
* Fix out_path argument and describe TOOLPATH pointing location Signed-off-by: Gabriel Ziegler <[email protected]> * Standardize arguments in examples to output_path Signed-off-by: Gabriel Ziegler <[email protected]>
1 parent f2070ae commit 43718c3

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed
 

‎fastmri_examples/cs/README.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@ which was used as a baseline model in
1212
The implementation uses the BART toolkit. To install BART, please follow the
1313
[installation instructions][bartlink].
1414

15-
Once BART is installed, set the `TOOLBOX_PATH` environment variable and point
16-
`PYTHONPATH` to the python wrapper for BART:
15+
Once BART is installed, set the `TOOLBOX_PATH` environment variable to point to the location where the repo was cloned and `PYTHONPATH` to the python wrapper for BART:
1716

1817
```bash
1918
export TOOLBOX_PATH=/path/to/bart
2019
export PYTHONPATH=${TOOLBOX_PATH}/python:${PYTHONPATH}
2120
```
2221

22+
where `/path/to/bart` is the path to the cloned BART repository, not your OS installed BART program.
23+
2324
To run the reconstruction algorithm on the validation data, run:
2425

2526
```bash

‎fastmri_examples/cs/run_bart.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def run_bart(args):
191191
time_taken = time.perf_counter() - start_time
192192

193193
logging.info(f"Run Time = {time_taken:} s")
194-
save_outputs(outputs, args.out_path)
194+
save_outputs(outputs, args.output_path)
195195

196196

197197
def create_arg_parser():
@@ -204,7 +204,7 @@ def create_arg_parser():
204204
help="Path to the data",
205205
)
206206
parser.add_argument(
207-
"--out_path",
207+
"--output_path",
208208
type=pathlib.Path,
209209
required=True,
210210
help="Path to save the reconstructions to",

‎fastmri_examples/zero_filled/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ To generate the zero-filled submissions, run:
1010
python run_zero_filled.py \
1111
--challenge CHALLENGE \
1212
--data_path DATA \
13-
--out_path RECONS
13+
--output_path RECONS
1414
```
1515

1616
where `CHALLENGE` is either `singlecoil` or `multicoil`.

‎fastmri_examples/zero_filled/run_zero_filled.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def create_arg_parser():
6363
help="Path to the data",
6464
)
6565
parser.add_argument(
66-
"--out_path",
66+
"--output_path",
6767
type=Path,
6868
required=True,
6969
help="Path to save the reconstructions to",
@@ -80,4 +80,4 @@ def create_arg_parser():
8080

8181
if __name__ == "__main__":
8282
args = create_arg_parser().parse_args()
83-
save_zero_filled(args.data_path, args.out_path, args.challenge)
83+
save_zero_filled(args.data_path, args.output_path, args.challenge)

0 commit comments

Comments
 (0)
Please sign in to comment.