-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varnet training default parameters #57
Comments
Hello @asaksena98, I can't think of any further reasons than the one you mentioned. If the network has never seen an acceleration other than 5x, you wouldn't expect it to perform well at 4x or 8x. |
@mmuckley I think OP trained using 4x and doesn't work well on 4x test set? the sample rate 0.2 refers to using a 1/5 subset? |
Ah in that case I misunderstood it. I'll try to check the model I ran when I get a chance to reproduce this. |
Sure, thank you! |
Hello @asaksena98, could you let me know if the items in PR #60 might address your issues? |
yup, i'll try running it with those changes |
Also, for the varnet submission on the public leaderboard, what acceleration rate was used for training? Since you can only submit one reconstructions zip file, I am unsure whether to train strictly on 4x, 8x or pass |
In that code there is some logic in the evaluation script that detects the acceleration level and runs the corresponding model. So it runs a 4x model for the 4x files and the 8x model for the 8x files. |
Hello, so i tried running the model after making the changes to |
Okay thanks for this information. I'm going to be putting out a PR on including |
sure, thank you! |
Hello @asaksena98, I don't know if you fixed this on your end, but I did discover an issue with how masks were handled in the test set that could cause a discrepancy between validation and leaderboard performance: This is fixed now in master. If this was your problem, you don't need to retrain; you just need to run with the new test script. Let me know if this helps. |
Sure, thank you for the update! |
Hello @asaksena98 any updates on your end? If not we can close this issue. |
Yup its resolved on my end. Thank you! |
Hello, I have been training the e2e varnet on 1 GPU with all the arguments set as default, except the sample rate is changed to 0.2. While the model performs quite well on the validation set (around 0.95 SSIM), it performs quite poorly on the public leaderboard for brain data (SSIM of 0.86 for 4x acceleration and 0.76 for 8x), and the images produced have lots of artifacts. My guess is that this occurs because the default acceleration rate is 4x and I should change it to either 8x or [4, 8], but I feel like there is more to this issue.
Apart from the sample and acceleration rate, are there any other potential reasons that might cause this issue?
The text was updated successfully, but these errors were encountered: