You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(cmake): drop FORTIFY_SOURCE=2 from release builds.
It causes weird issues with zig finding the prototypes for `strlcat` and `strlcpy` in
`lib/libc/include/generic-glibc/bits/string_fortified.h`,
but their implementation is not present, leading to link time build failure.
This means:
* check_symbol_exists(strlcpy "string.h" HAVE_STRLCPY) fails
* `HAVE_STRLCPY` and `HAVE_STRLCAT` are not defined
* `<libscap/strl.h>` defines both `strlcat` and `strlcpy`
* but `string.h` included at the start of `strl.h` will find the prototypes, thus failing because of symbol redefinition
Signed-off-by: Federico Di Pierro <[email protected]>
0 commit comments