Skip to content

Commit 84ad86e

Browse files
FedeDPleogr
andcommitted
chore(docker): apply some review suggestions.
Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Leonardo Grasso <[email protected]>
1 parent a679e44 commit 84ad86e

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

docker/driver-loader-buster/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM debian:buster
33
LABEL maintainer="[email protected]"
44
LABEL org.opencontainers.image.source="https://github.com/falcosecurity/falco"
55

6-
LABEL usage="docker run -i -t --privileged -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro -v /etc:/host/etc --name NAME IMAGE"
6+
LABEL usage="docker run -i -t --privileged -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro -v /etc:/host/etc falcosecurity/falco-driver-loader:latest-buster"
77

88
ARG TARGETARCH
99

@@ -130,3 +130,5 @@ RUN curl -L -o falcoct.tar.gz $(curl -s "https://api.github.com/repos/falcosecur
130130
COPY ./docker-entrypoint.sh /
131131

132132
ENTRYPOINT ["/docker-entrypoint.sh"]
133+
134+
CMD ["/usr/bin/falco"]

docker/driver-loader-buster/docker-entrypoint.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,4 +125,4 @@ fi
125125

126126
/usr/bin/falcoctl driver install --compile=$ENABLE_COMPILE --download=$ENABLE_DOWNLOAD --http-insecure=$HTTP_INSECURE --http-headers="$FALCOCTL_DRIVER_HTTP_HEADERS"
127127

128-
exec /usr/bin/falco
128+
exec "$@"

docker/driver-loader/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ FROM docker.io/falcosecurity/falco:${FALCO_IMAGE_TAG}-debian
44
LABEL maintainer="[email protected]"
55
LABEL org.opencontainers.image.source="https://github.com/falcosecurity/falco"
66

7-
LABEL usage="docker run -i -t --privileged -v /root/.falco:/root/.falco -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro -v /etc:/host/etc:ro --name NAME IMAGE"
7+
LABEL usage="docker run -i -t --privileged -v /root/.falco:/root/.falco -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro -v /etc:/host/etc:ro falcosecurity/falco-driver-loader:latest"
88

99
ENV HOST_ROOT /host
1010
ENV HOME /root
@@ -48,3 +48,5 @@ RUN rm -df /lib/modules \
4848
COPY ./docker-entrypoint.sh /
4949

5050
ENTRYPOINT ["/docker-entrypoint.sh"]
51+
52+
CMD ["/usr/bin/falco"]

docker/driver-loader/docker-entrypoint.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,4 +137,4 @@ fi
137137

138138
/usr/bin/falcoctl driver install --compile=$ENABLE_COMPILE --download=$ENABLE_DOWNLOAD --http-insecure=$HTTP_INSECURE --http-headers="$FALCOCTL_DRIVER_HTTP_HEADERS" $extra_args
139139

140-
exec /usr/bin/falco
140+
exec "$@"

docker/falco-debian/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM debian:12-slim
33
LABEL maintainer="[email protected]"
44
LABEL org.opencontainers.image.source="https://github.com/falcosecurity/falco/docker/falco-debian"
55

6-
LABEL usage="docker run -i -t -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro --name NAME IMAGE"
6+
LABEL usage="docker run -i -t -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro falcosecurity/falco:latest-debian"
77

88
ARG FALCO_VERSION
99
ARG VERSION_BUCKET=deb

docker/falco/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM cgr.dev/chainguard/wolfi-base
33
LABEL maintainer="[email protected]"
44
LABEL org.opencontainers.image.source="https://github.com/falcosecurity/falco"
55

6-
LABEL usage="docker run -i -t --privileged -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro --name NAME IMAGE"
6+
LABEL usage="docker run -i -t --privileged -v /var/run/docker.sock:/host/var/run/docker.sock -v /proc:/host/proc:ro -v /etc:/host/etc:ro falcosecurity/falco:latest"
77
# NOTE: for the "least privileged" use case, please refer to the official documentation
88

99
ARG FALCO_VERSION

0 commit comments

Comments
 (0)