Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wchar_t API for windows file operation in standardpath #1256

Open
wengxt opened this issue Feb 3, 2025 · 2 comments
Open

Use wchar_t API for windows file operation in standardpath #1256

wengxt opened this issue Feb 3, 2025 · 2 comments

Comments

@wengxt
Copy link
Member

wengxt commented Feb 3, 2025

Summary

It is well known about the encoding issue on windows. So prefer to use _w variant instead of POSIX ones on windows.

@wengxt
Copy link
Member Author

wengxt commented Feb 24, 2025

Using std::filesystem::path instead of std::string will be part of this project, so we can get the native path char type for free.

@wengxt
Copy link
Member Author

wengxt commented Mar 14, 2025

current plan is to create a new class for standard path at the same time, simplify the existing api and mark the o ld one as deprecated.

The pattern we really need are:

  1. open a fixed file name (reloadConfig)
  2. load all file with a pattern (e.g. all dict, all .conf). prefer to load one by one instead of open all at the same time. There was a bug that hit the os file descriptor limit.
  3. timestamp we still need.
  4. icon theme need the open all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant