Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to execute 'querySelector' on 'Element': 'input[name=company.country],textarea[name=company.country],select[name=company.country]' is not a valid selector. #7

Closed
intergalacticspacehighway opened this issue Aug 11, 2018 · 1 comment

Comments

@intergalacticspacehighway

Are you submitting a bug report or a feature request?

  • Feature Request

What is the current behavior?

  • The current version is not supporting Field with Object.Key pattern name which is supported by react-final-form's Field component.
  • When such a name pattern is used it creates an incorrect node selector i.e 'input[name=company.country]'.

What is the expected behavior?

  • Field Component should support object.key naming pattern.

Sandbox Link

What's your environment?

  • final-form v4.8.3
  • react-final-form v3.6.5
  • react-final-form-html5-validation v1.0.1
  • Node v8.9
  • npm v6.3

Other information

Solution which i have found.

  • This issue can be fixed by surrounding the name with quotes.
    input = root.querySelector(input[name="${name}"],textarea[name="${name}"],select[name="${name}"]);
@erikras
Copy link
Member

erikras commented Sep 6, 2018

Published fix in v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants