Skip to content

Commit a3fcfe9

Browse files
chore: update readme
1 parent 5cd0438 commit a3fcfe9

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

integration_test/README.md

+4-6
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,12 @@ yarn start
2929
[x] Update existing tests to use jest (v1 and v2)
3030
[x] Add missing coverage for v1 and v2 (WIP)
3131
[x] Ensure proper teardown of resources (only those for current test run)
32-
[] Check that we are properly tearing down all docs as side-effects
33-
[] Analytics: since you cannot directly trigger onLog events from Firebase Analytics in a CI environment, the primary strategy is to isolate and test the logic within the Cloud Functions by mocking Firebase services and the Analytics event data. This is done elsewhere via unit tests, so no additional coverage necessary.
34-
[] Alerts: same as analytics
35-
[] Auth blocking functions can only be deployed one at a time, half-way solution is to deploy v1 functions, run v1 tests, teardown, and repeat for v2. However, this still won't allow for multiple runs to happen in parallel. Solution needed before re-enabling auth/identity tests.
36-
[] Https tests were commented out previously, comments remain as before for same reasons
32+
[] Analytics: since you cannot directly trigger onLog events from Firebase Analytics in a CI environment, the primary strategy is to isolate and test the logic within the Cloud Functions by mocking Firebase services and the Analytics event data. This is done elsewhere via unit tests, so no additional coverage added.
33+
[] Alerts: same as analytics, couldn't find way to trigger.
34+
[] Auth blocking functions can only be deployed one at a time, half-way solution is to deploy v1 functions, run v1 tests, teardown, and repeat for v2. However, this still won't allow for multiple runs to happen in parallel. Solution needed before re-enabling auth/identity tests. You can run the suite with either v1 or v2 commented out to check test runs.
35+
[] Https tests were commented out previously, comments remain as before
3736
[] Python runtime support
3837

3938
## Troubleshooting
4039

4140
- Sometimes I ran into this reported [issue](https://github.com/firebase/firebase-tools/issues/793), I had to give it some period of time and attempt deploy again. Probably an upstream issue but may affect our approach here. Seems to struggle with deploying the large amount of trigger functions...? Falls over on Firebase Storage functions (if you comment these out everything else deploys as expected).
42-
- Ensure service account has the necessary permissions for each service, and enable object versioning for the storage onArchive tests.

integration_test/tests/v2/storage.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as admin from "firebase-admin";
2-
import { timeout } from "../../tests/utils";
3-
import { initializeFirebase } from "../../tests/firebaseSetup";
2+
import { timeout } from "../utils";
3+
import { initializeFirebase } from "../firebaseSetup";
44

55
async function uploadBufferToFirebase(buffer: Buffer, fileName: string) {
66
const bucket = admin.storage().bucket();

0 commit comments

Comments
 (0)