Use await import instead of require for functions modules that contain top-level awaits (#1651)

* Use await import instead of require for functions modules that contain top-level awaits

* tests ensuring that es modules with top level awaits can be loaded

* adds node 22 to the CI matrix on github

* Add support for an authPolicy that returns Permission Denied when failed (#1650)

* Add support for an authPolicy that returns Permission Denied when failed

* Formatter

* Changelog

* remove ignorant comment

* Update streaming callable API (#1652)

* Update streaming callable API

* Fix linter error

* Stream type defaults to unknown

* Changelog

* Format fix

* update changelog.md

---------

Co-authored-by: Thomas Bouldin <[email protected]>

Author: Berlioz

.github/workflows/test.yaml

@@ -32,6 +32,7 @@ jobs:
         node-version:
           - 18.x
           - 20.x
+          - 22.x
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1
@@ -52,6 +53,7 @@ jobs:
         node-version:
           - 18.x
           - 20.x
+          - 22.x
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1

CHANGELOG.md

@@ -1,2 +1,3 @@
 - Add an authPolicy callback to CallableOptions for reusable auth middleware as well as helper auth policies (#1650)
+- Handle ESM functions codebases containing top-level awaits, which would break in node 22.12+ (#1651)
 - Multiple breaking changes to the not-yet-announced streaming feature for Callable Functions (#1652)

scripts/bin-test/sources/esm-top-level-await/exports.js

@@ -0,0 +1,3 @@
+export const fn = () => {
+  return null;
+}

scripts/bin-test/sources/esm-top-level-await/index.js

@@ -0,0 +1,8 @@
+import * as functionsv2 from "firebase-functions/v2";
+
+const { fn } = await import('./exports.js');
+
+export const v2http = functionsv2.https.onRequest((req, resp) => {
+    fn()
+    resp.status(200).send("PASS");
+});

scripts/bin-test/sources/esm-top-level-await/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "esm",
+  "type": "module"
+}

src/runtime/loader.ts

@@ -48,8 +48,8 @@ async function loadModule(functionsDir: string) {
   try {
     return require(path.resolve(absolutePath));
   } catch (e) {
-    if (e.code === "ERR_REQUIRE_ESM") {
-      // This is an ESM package!
+    if (e.code === "ERR_REQUIRE_ESM" || e.code === "ERR_REQUIRE_ASYNC_MODULE") {
+      // This is an ESM package, or one containing top-level awaits!
       const modulePath = require.resolve(absolutePath);
       // Resolve module path to file:// URL. Required for windows support.
       const moduleURL = url.pathToFileURL(modulePath).href;