Skip to content

Commit c02a944

Browse files
committed
Don't track unobserved task exceptions
I think this will resolve #7, #9, #10, #11, #12, #13, #14, #15, #16, #17, #18
1 parent ac34621 commit c02a944

File tree

7 files changed

+23
-6
lines changed

7 files changed

+23
-6
lines changed

Demo/MyXslProject/BadXml.xslt

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" encoding="utf-8"?
2+
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
3+
xmlns:msxsl="urn:schemas-microsoft-com:xslt" exclude-result-prefixes="msxsl"
4+
>
5+
<xsl:output method="xml" indent="yes"/>
6+
7+
<xsl:template match="@* | node()">
8+
<xsl:copy>
9+
<xsl:apply-templates select="@* | node()"/>
10+
</xsl:copy>
11+
</xsl:template>
12+
</xsl:stylesheet>

Demo/MyXslProject/MyXslProject.csproj

+3
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@
4747
<Content Include="Bad.xslt">
4848
<SubType>Designer</SubType>
4949
</Content>
50+
<Content Include="BadXml.xslt">
51+
<SubType>Designer</SubType>
52+
</Content>
5053
<Content Include="Second.xslt" />
5154
<Content Include="First.xslt">
5255
<SubType>Designer</SubType>

src/Gardiner.XsltTools/HockeyClientTelemetryProvider.cs

+3-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,9 @@ private async Task Configure()
3939
if (string.IsNullOrEmpty(_hockeyClient.AppIdentifier))
4040
{
4141
// We must only call Configure once
42-
_hockeyClient.Configure("bb59fd06bb2a42aab4dff8125de22209")
43-
.RegisterDefaultUnobservedTaskExceptionHandler();
42+
_hockeyClient.Configure("bb59fd06bb2a42aab4dff8125de22209");
43+
// Suspect this is tracking ANY exception in Visual Studio - not just from our code
44+
//.RegisterDefaultUnobservedTaskExceptionHandler();
4445
}
4546
var helper = new HockeyPlatformHelperWPF();
4647

src/Gardiner.XsltTools/Properties/AssemblyInfo.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
// You can specify all the values or you can default the Build and Revision Numbers
3131
// by using the '*' as shown below:
3232
// [assembly: AssemblyVersion("1.0.*")]
33-
[assembly: AssemblyVersion("1.1.0.0")]
34-
[assembly: AssemblyFileVersion("1.1.0.0")]
33+
[assembly: AssemblyVersion("1.1.1.0")]
34+
[assembly: AssemblyFileVersion("1.1.1.0")]
3535

3636
[assembly: NeutralResourcesLanguage("en")]

src/Gardiner.XsltTools/XsltChecker.cs

+1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ public AccessibilityResult CheckFile(string filename)
7676
catch (XmlException)
7777
{
7878
// Must have been a weird XML document. Just ignore
79+
Debug.WriteLine("Invalid XML document. Ignoring");
7980
}
8081

8182

src/Gardiner.XsltTools/source.extension.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ static class Vsix
1313
1414
Runs on Build, and lists any rule violations in the Error List window";
1515
public const string Language = "en-US";
16-
public const string Version = "1.1";
16+
public const string Version = "1.1.1";
1717
public const string Author = "David Gardiner";
1818
public const string Tags = "xslt, static analysis, fxcop";
1919
}

src/Gardiner.XsltTools/source.extension.vsixmanifest

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="Gardiner.XsltTools.David Gardiner.9f30a511-362f-4ebe-bc2d-4b987c1b9a96" Version="1.1" Language="en-US" Publisher="David Gardiner" />
4+
<Identity Id="Gardiner.XsltTools.David Gardiner.9f30a511-362f-4ebe-bc2d-4b987c1b9a96" Version="1.1.1" Language="en-US" Publisher="David Gardiner" />
55
<DisplayName>XsltCop</DisplayName>
66
<Description xml:space="preserve">Static analysis tool to enhance editing and checking for common mistakes in XSLT files.
77

0 commit comments

Comments
 (0)