Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second argument of applyChange from public api #115

Closed
fedulovivan opened this issue Sep 5, 2017 · 1 comment
Closed

Remove second argument of applyChange from public api #115

fedulovivan opened this issue Sep 5, 2017 · 1 comment

Comments

@fedulovivan
Copy link

diff/index.js

Line 260 in c97fb9c

if (target && source && change && change.kind) {

Hello! First of all thanks for a nice tool.

Is it possible to completely remove second argument 'source' from public api of applyChange utility?
Even it is not really used (and docs clearly state this), function checks that passed source is 'truthy',
so a have to use following pattern:

changes.forEach(change => applyChange(
    INITIAL_STATE,
    true/*stated as not used in docs, but have to be truthy to pass internal checks*/, 
    change
))
@flitbit flitbit self-assigned this Feb 26, 2018
@flitbit
Copy link
Collaborator

flitbit commented Apr 18, 2018

My bad, got distracted and never released v1.0.0... doing that now.

@flitbit flitbit removed their assignment Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant