Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌘W should close last open window #36

Closed
jbergstroem opened this issue May 26, 2017 · 4 comments
Closed

⌘W should close last open window #36

jbergstroem opened this issue May 26, 2017 · 4 comments
Milestone

Comments

@jbergstroem
Copy link

It currently has a 'untitled' tab which quickly reopens again.

@dmay
Copy link

dmay commented May 26, 2017

⌘W Should close window if it only has one tab, you mean?
I would +1 it.

[        Window        ]
[   Rep1   ][  *Rep2   ]

⌘W

[        Window        ]
[        *Rep1         ]

⌘W

Expected:

No window

Actual:

[        Window        ]
[      *Untitled       ]

@jbergstroem
Copy link
Author

@dmay said:
⌘W Should close window if it only has one tab, you mean?

Yeah; a more descriptive comment could have been connecting the analogy of "one window" = "one window with tab", but since fork is basically one window only, I didn't. Thanks for clarifying!

@DanPristupov
Copy link
Contributor

There's an option in the preferences: Quit when all tabs are closed.

And yes, currently Fork is limited to 1 window (which is a mistake which I didn't realize at the time).

@jfexyz
Copy link

jfexyz commented Jan 24, 2018

Yes, the preference will mostly work for me, but this is how I'd ideally like it to work:

  • cmd-w closes each tab, one at at time
  • with one tab remaining, cmd-w closes last tab
  • shows window with repository list (as it currently does). probably needs a better name than "Untitled" however
  • cmd-w again closes the entire window (or I guess in this case, quits the app)

I think the preference could be removed, as the above is how Mac apps generally work (the quitting is unusual, so maybe this needs to wait until it supports multiple windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants