Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpm-setup action broken by Continuous Deployment Changes #6

Closed
everythingfunctional opened this issue Nov 2, 2021 · 4 comments · Fixed by #7
Closed

fpm-setup action broken by Continuous Deployment Changes #6

everythingfunctional opened this issue Nov 2, 2021 · 4 comments · Fixed by #7
Labels
bug Something isn't working

Comments

@everythingfunctional
Copy link
Member

Description

Not sure whether to report the bug here or at the fpm-setup repo, but the latest changes appear to have broken that action.

Expected Behaviour

The action is trying to download the "latest" version of fpm, which is now, presumably the "current" Release, but the binaries don't follow the same naming convention (i.e. fpm-<version>-linux-x86_64. Is the recommended usage to specify an fpm version with the action, or should something be changed?

Version of fpm

current

Platform and Architecture

Linux, Windows and MacOS

Additional Information

Output from running the action

Run fortran-lang/setup-fpm@v3
  with:
    github-token: ***
    use-haskell: false
    fpm-version: latest
    fpm-repository: https://github.com/fortran-lang/fpm
  env:
    FC: gfortran
    GCC_V: 11
use-haskell: false
fpm-version: latest
fpm-repository: https://github.com/fortran-lang/fpm
This platform is linux
Fetching fpm from https://github.com/fortran-lang/fpm/releases/download/current/fpm-current-linux-x86_64
Error: Error while trying to fetch fpm - please check that a version exists at the above release url.
undefined
Error: The "path" argument must be of type string. Received type undefined
@awvwgk awvwgk transferred this issue from fortran-lang/fpm Nov 3, 2021
@awvwgk awvwgk added the bug Something isn't working label Nov 3, 2021
@awvwgk
Copy link
Member

awvwgk commented Nov 3, 2021

When selecting the latest version, the latest stable version should be targeted rather than the one we deploy continuously.

@everythingfunctional
Copy link
Member Author

Looking at the code that determines the latest release version (here), it seems that we can now assume that current will always be the "latest", so we should take the second (e.g. index 1 instead of 0), instead of the first release here.

I can submit a PR if you think that's correct and you don't want to make the change yourself.

@awvwgk
Copy link
Member

awvwgk commented Nov 3, 2021

There is always the possibility to check for the latest release https://github.com/fortran-lang/fpm/releases/latest rather than checking for the newest tag.

@awvwgk
Copy link
Member

awvwgk commented Nov 6, 2021

Fixed by #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants