Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual makefile does not clean fypp generated test files #533

Closed
awvwgk opened this issue Sep 19, 2021 · 1 comment
Closed

Manual makefile does not clean fypp generated test files #533

awvwgk opened this issue Sep 19, 2021 · 1 comment
Labels
build: make Issue with stdlib's manual makefile build

Comments

@awvwgk
Copy link
Member

awvwgk commented Sep 19, 2021

The test_median is currently using fypp to generate the actual test file:

stdlib/src/tests/stats/Makefile.manual

Lines 1 to 7 in 8bfcdf9

SRCFYPP =\
test_median.fypp
SRCGEN = $(SRCFYPP:.fypp=.f90)
$(SRCGEN): %.f90: %.fypp common.fypp
fypp $(FYPPFLAGS) $< $@

Since the include makefile for generating the tests is not aware of the fypp usage the clean command is not working correctly. Running the manual makefile will leave a stale build artifact in the source tree which can be picked when doing a local fpm export using the ci/fpm-deployment.sh script or by the CMake build files.
@awvwgk awvwgk added the build: make Issue with stdlib's manual makefile build label Sep 19, 2021
@ivan-pi
Copy link
Member

ivan-pi commented May 19, 2022

Closing due to #657 (Remove support for manual make builds).

@ivan-pi ivan-pi closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build: make Issue with stdlib's manual makefile build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivan-pi @awvwgk