do not output potentially unsafe content, fixes GHSA-26xq-m8xw-6373

d00p · d00p · commit fde43f80600f · 2025-01-12T10:27:44.000+01:00
Signed-off-by: Michael Kaufmann &lt;d00p@froxlor.org&gt;
diff --git a/lib/Froxlor/Api/Commands/SubDomains.php b/lib/Froxlor/Api/Commands/SubDomains.php
@@ -503,8 +503,7 @@ public function get()
 			$this->logger()->logAction($this->isAdmin() ? FroxlorLogger::ADM_ACTION : FroxlorLogger::USR_ACTION, LOG_INFO, "[API] get subdomain '" . $result['domain'] . "'");
 			return $this->response($result);
 		}
-		$key = ($id > 0 ? "id #" . $id : "domainname '" . $domainname . "'");
-		throw new Exception("Subdomain with " . $key . " could not be found", 404);
+		throw new Exception("Requested subdomain could not be found", 404);
 	}
 
 	private function getHasCertValueForDomain(int $domainid, int $parentdomainid): int

Original file line number	Diff line number	Diff line change
`@@ -503,8 +503,7 @@ public function get()`
`503`	`503`	`$this->logger()->logAction($this->isAdmin() ? FroxlorLogger::ADM_ACTION : FroxlorLogger::USR_ACTION, LOG_INFO, "[API] get subdomain '" . $result['domain'] . "'");`
`504`	`504`	`return $this->response($result);`
`505`	`505`	`}`
`506`		`- $key = ($id > 0 ? "id #" . $id : "domainname '" . $domainname . "'");`
`507`		`- throw new Exception("Subdomain with " . $key . " could not be found", 404);`
	`506`	`+ throw new Exception("Requested subdomain could not be found", 404);`
`508`	`507`	`}`
`509`	`508`
`510`	`509`	`private function getHasCertValueForDomain(int $domainid, int $parentdomainid): int`