Skip to content

Add prop types as dependency #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

leanbalma
Copy link
Contributor

Added prop-types as a dependency in package.json.
Resolves #817.

@leanbalma leanbalma changed the base branch from master to next January 25, 2018 15:24
@theKashey
Copy link
Collaborator

Did you mean packages/react-hot-loader/packages.json? The one exposed as react-hot-loader to npm.

@leanbalma leanbalma force-pushed the add-prop-types-dependency branch from cc363d0 to 95fa594 Compare January 25, 2018 21:58
@codecov-io
Copy link

codecov-io commented Jan 25, 2018

Codecov Report

Merging #823 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #823   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files          23       23           
  Lines         504      504           
  Branches      140       91   -49     
=======================================
  Hits          428      428           
- Misses         56       61    +5     
+ Partials       20       15    -5
Impacted Files Coverage Δ
...-hot-loader/src/reconciler/hotReplacementRender.js 87.17% <0%> (ø) ⬆️
...ot-loader/src/internal/stack/hydrateLegacyStack.js 8.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6508461...55cbb56. Read the comment docs.

@theKashey
Copy link
Collaborator

👍

@leanbalma
Copy link
Contributor Author

Thank you. Sorry about that.

@gregberge
Copy link
Collaborator

Thanks for it. Just a little problem, this project is using yarn. You have to install it with yarn, to do it just run yarn at the root of the project then go in packages/react-hot-loader and run yarn add prop-types.

@leanbalma leanbalma force-pushed the add-prop-types-dependency branch from 95fa594 to 55cbb56 Compare January 26, 2018 14:49
@leanbalma
Copy link
Contributor Author

Right. I have to include the yarn.lock file too :) Fixed.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants