Skip to content

Commit 92de014

Browse files
committed
fix: Downgrade Protobuf from 4.x to 3.x
Motivation: - grpc-java is not fully compatible with Protobuf 4; see: grpc/grpc-java#11015 - Protobuf 4 breaks our demo server due to an incompatibility between the generated code and what the grpc-java library expects. Modifications: - Downgrade to Protobuf 3 on all projects. - Prevent upgrade to Protobuf 4 in dependabot.yml (note: scala-steward doesn't seem to pick up Protobuf updates anyway, probably because it's not configured as a library dependency per se). Result: Stick to Protobuf 3 for now.
1 parent 1e5e4ff commit 92de014

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

.github/dependabot.yml

+15
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,19 @@ updates:
77
schedule:
88
interval: "weekly"
99
day: "sunday"
10+
ignore:
11+
- dependency-name: "com.google.protobuf:protoc"
12+
versions: ['>= 4'] # https://github.com/grpc/grpc-java/issues/11015
1013
- package-ecosystem: "maven"
1114
directory: "/java/maven"
1215
commit-message:
1316
prefix: "chore"
1417
schedule:
1518
interval: "weekly"
1619
day: "sunday"
20+
ignore:
21+
- dependency-name: "com.google.protobuf:protoc"
22+
versions: ['>= 4'] # https://github.com/grpc/grpc-java/issues/11015
1723
- package-ecosystem: "gradle"
1824
directory: "/kotlin/gradle"
1925
commit-message:
@@ -25,13 +31,19 @@ updates:
2531
schedule:
2632
interval: "weekly"
2733
day: "sunday"
34+
ignore:
35+
- dependency-name: "com.google.protobuf:protoc"
36+
versions: ['>= 4'] # https://github.com/grpc/grpc-java/issues/11015
2837
- package-ecosystem: "maven"
2938
directory: "/kotlin/maven"
3039
commit-message:
3140
prefix: "chore"
3241
schedule:
3342
interval: "weekly"
3443
day: "sunday"
44+
ignore:
45+
- dependency-name: "com.google.protobuf:protoc"
46+
versions: ['>= 4'] # https://github.com/grpc/grpc-java/issues/11015
3547
- package-ecosystem: "gradle"
3648
directory: "/server"
3749
commit-message:
@@ -43,3 +55,6 @@ updates:
4355
schedule:
4456
interval: "weekly"
4557
day: "sunday"
58+
ignore:
59+
- dependency-name: "com.google.protobuf:protoc"
60+
versions: ['>= 4'] # https://github.com/grpc/grpc-java/issues/11015

java/gradle/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ sourceSets {
4343

4444
protobuf {
4545
protoc {
46-
artifact = "com.google.protobuf:protoc:4.26.0"
46+
artifact = "com.google.protobuf:protoc:3.25.3"
4747
}
4848
plugins {
4949
grpc {

java/maven/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<gatling-maven-plugin.version>4.8.2</gatling-maven-plugin.version>
2020
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
2121
<maven-jar-plugin.version>3.3.0</maven-jar-plugin.version>
22-
<protobuf.version>3.24.2</protobuf.version>
22+
<protobuf.version>3.25.3</protobuf.version>
2323
<protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
2424
<protoc-gen-grpc-java.version>1.57.2</protoc-gen-grpc-java.version>
2525
<spotless.version>2.43.0</spotless.version>

kotlin/maven/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
2222
<maven-jar-plugin.version>3.3.0</maven-jar-plugin.version>
2323
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
24-
<protobuf.version>4.26.0</protobuf.version>
24+
<protobuf.version>3.25.3</protobuf.version>
2525
<protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
2626
<protoc-gen-grpc-java.version>1.57.2</protoc-gen-grpc-java.version>
2727
<spotless.version>2.43.0</spotless.version>

server/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ idea {
2727

2828
protobuf {
2929
protoc {
30-
artifact = "com.google.protobuf:protoc:4.26.0"
30+
artifact = "com.google.protobuf:protoc:3.25.3"
3131
}
3232
plugins {
3333
grpc {

0 commit comments

Comments
 (0)