chore(gatsby, gatsby-transformer-remark, gatsby-plugin-sharp): Cleanup v4 compile flag conditions #36486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
marvinjude
changed the title
marvinjude
added
type: maintenance
wardpeet
reviewed
Aug 29, 2022
| } | ||
| exports.onPluginInit = async ({ actions }, pluginOptions) => { | ||
| setActions(actions) | ||
| setPluginOptions(pluginOptions) | ||
| } | ||
| } |
There was a problem hiding this comment.
This can be used instead of the whole try catch
exports.onPluginInit = async ({ actions }, pluginOptions) => {
setActions(actions)
setPluginOptions(pluginOptions)
}
There was a problem hiding this comment.
Do you mean removing the if (coreSupportsOnPluginInit) { check ?
wardpeet
reviewed
Aug 29, 2022
Co-authored-by: Ward Peeters <[email protected]>
wardpeet
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for v5 canaries, This PR makes codepaths behind
_CFLAGS_.GATSBY_MAJOR === 4conditions the default and also removes non_CFLAGS_.GATSBY_MAJOR === 4codepaths.[sc-54975]