Skip to content

Commit a8c17d1

Browse files
authored
Small cleanup (#580)
1 parent 57f27b0 commit a8c17d1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

Diff for: cmds/genimgs/genimgs.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
"sort"
3131
"strings"
3232
"sync"
33+
"time"
3334

3435
awsconfig "github.com/aws/aws-sdk-go-v2/config"
3536
s3manager "github.com/aws/aws-sdk-go-v2/feature/s3/manager"
@@ -466,6 +467,9 @@ func createImage(img generateImage) error {
466467
}
467468

468469
func (c *client) uploadImage(ctx context.Context, img generateImage) error {
470+
ctx, cancel := context.WithTimeout(ctx, 30*time.Second)
471+
defer cancel()
472+
469473
f, err := os.Open(img.outputPath)
470474
if err != nil {
471475
return err
@@ -513,19 +517,17 @@ func createWebpImage(img generateImage) error {
513517
if err != nil {
514518
return err
515519
}
520+
defer f.Close()
516521

517-
err = webp.Encode(f, dst, nil)
518-
if err != nil {
519-
return err
520-
}
521-
return nil
522+
return webp.Encode(f, dst, nil)
522523
}
523524

524525
func createAvifImage(img generateImage) error {
525526
tmpDir, err := ioutil.TempDir("", "")
526527
if err != nil {
527528
return err
528529
}
530+
defer os.RemoveAll(tmpDir) // Clean up temporary directory
529531

530532
origExt := path.Ext(img.originalPath)
531533
outputExt := path.Ext(img.outputPath)

0 commit comments

Comments
 (0)