Skip to content

Commit ec3d2ed

Browse files
committed
fix ameba warnings
1 parent cc94a83 commit ec3d2ed

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/convex_hull/algorithm.cr

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module ConvexHull
88
def initialize(points : Array(Tuple(Int32 | Float32 | Float64, Int32 | Float32 | Float64)))
99
raise "There must be at least 3 points" if points.size < 3
1010

11-
points = points.uniq.map { |p| Point.new(p[0], p[1]) }.sort!
11+
points = points.uniq.map { |point| Point.new(point[0], point[1]) }.sort!
1212

1313
@convex_hull = convex_hull(points)
1414
end

src/convex_hull/graham_scan.cr

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@ module ConvexHull
33
private def convex_hull(points) : Array(Point)
44
lower = Array(Point).new
55

6-
points.each do |p|
7-
while lower.size > 1 && cross(lower[-2], lower[-1], p) <= 0
6+
points.each do |point|
7+
while lower.size > 1 && cross(lower[-2], lower[-1], point) <= 0
88
lower.pop
99
end
1010

11-
lower.push(p)
11+
lower.push(point)
1212
end
1313

1414
upper = Array(Point).new
1515

16-
points.reverse_each do |p|
17-
while upper.size > 1 && cross(upper[-2], upper[-1], p) <= 0
16+
points.reverse_each do |point|
17+
while upper.size > 1 && cross(upper[-2], upper[-1], point) <= 0
1818
upper.pop
1919
end
2020

21-
upper.push(p)
21+
upper.push(point)
2222
end
2323

2424
hull = lower[...-1] + upper[...-1]

0 commit comments

Comments
 (0)