Skip to content

fix(DrawControl): add drawInteractionOptions for DrawControl #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 11, 2022

Conversation

danji90
Copy link
Contributor

@danji90 danji90 commented Aug 11, 2022

How to

Adds the possibility to configure the ol Draw interaction's options by passing it in through the options of the DrawControl

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • IE11 tested.
  • The title is formatted as a conventional-commit message.
  • The title contains WIP: if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

IMPORTANT: Squash commits before or on merge to prevent every small commit being written into the change log. The Pull Request title will be written as message for the new commit containing the squashed commits and there fore needs to be in conventional-commit format

@danji90 danji90 requested a review from oterral August 11, 2022 07:28
@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
openlayers-editor ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 8:27AM (UTC)

@danji90 danji90 merged commit e1ceb7c into master Aug 11, 2022
@oterral oterral deleted the daniel/drawInteractionOptions branch April 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants