Skip to content

Commit f4ce52f

Browse files
committed
ncu-ci: parse node-test-pull-request-lite-pipeline pipelines
Fixes: nodejs/node-core-utils#259
1 parent a70d0c7 commit f4ce52f

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

lib/ci/ci_type_parser.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const CI_TYPES = new Map([
8686
[LITE_PR_PIPELINE, {
8787
name: 'Lite PR Pipeline',
8888
jobName: 'node-test-pull-request-lite-pipeline',
89-
pattern: /job\/node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/,
89+
pattern: /node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/,
9090
type: LITE_CI
9191
}],
9292
[LITE_COMMIT, {
@@ -120,8 +120,7 @@ function parseJobFromURL(url) {
120120
}
121121

122122
for (let [ type, info ] of CI_TYPES) {
123-
const re = new RegExp(`job/${info.jobName}/(\\d+)`);
124-
const match = url.match(re);
123+
const match = url.match(info.pattern);
125124
if (match) {
126125
return {
127126
link: url,

test/unit/ci_type_parser.test.js

+14-1
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,23 @@ const expected = new Map([
5656
jobid: 7213
5757
}]
5858
]);
59-
6059
describe('JobParser', () => {
6160
it('should parse CI results', () => {
6261
const results = new JobParser(commentsWithCI).parse();
6362
assert.deepStrictEqual([...results.entries()], [...expected.entries()]);
6463
});
64+
65+
it('should parse pipeline links', () => {
66+
const data = [{
67+
'publishedAt': '2017-10-29T04:16:36.458Z',
68+
'bodyText': '@contributer build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3009/pipeline/'
69+
}];
70+
const results = new JobParser(data).parse();
71+
assert.deepStrictEqual([...results.entries()], [
72+
['LITE_PR_PIPELINE', {
73+
link: 'https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3009/pipeline/',
74+
date: '2017-10-29T04:16:36.458Z',
75+
jobid: 3009
76+
}]]);
77+
});
6578
});

0 commit comments

Comments
 (0)