fix: Limit concurrent FS calls to prevent memory fragmentation

Author: kamilogorek

packages/raven-node/lib/utils.js

@@ -18,7 +18,7 @@ var protocolMap = {
 
 var consoleAlerts = new Set();
 
-var fsLimiter = new Limiter({concurrency: 25);
+var fsLimiter = new Limiter({concurrency: 25});
 
 // Default Node.js REPL depth
 var MAX_SERIALIZE_EXCEPTION_DEPTH = 3;
@@ -282,7 +282,7 @@ function readSourceFiles(filenames, cb) {
   var sourceFiles = {};
   var numFilesToRead = filenames.length;
   return filenames.forEach(function(filename) {
-    fsLimiter.push(function (done) {
+    fsLimiter.push(function(done) {
       fs.readFile(filename, function(readErr, file) {
         done();
 

packages/utils/.gitignore

@@ -1,3 +1,4 @@
 *.js.map
 *.d.ts
+!src/*.d.ts
 *.js

packages/utils/package.json

@@ -14,6 +14,7 @@
   },
   "dependencies": {
     "@sentry/types": "4.4.1",
+    "async-limiter": "^1.0.0",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

packages/utils/src/declarations.d.ts

@@ -0,0 +1 @@
+declare module 'async-limiter';

packages/utils/src/fs.ts

@@ -1,25 +1,32 @@
+import * as Limiter from 'async-limiter';
 import { mkdir, mkdirSync, readFile, statSync } from 'fs';
 import { dirname, resolve } from 'path';
 
+// tslint:disable-next-line:no-unsafe-any
+const fsLimiter = new Limiter({ concurrency: 25 });
 const _0777 = parseInt('0777', 8);
 
 /**
- * Asynchronously creates the given directory.
+ * Asynchronously reads given files content.
  *
- * @param path A relative or absolute path to the directory.
- * @param mode The permission mode.
- * @returns A Promise that resolves when the path has been created.
+ * @param path A relative or absolute path to the file
+ * @returns A Promise that resolves when the file has been read.
  */
 export async function readFileAsync(path: string): Promise<Error | string> {
   // We cannot use util.promisify here because that was only introduced in Node
   // 8 and we need to support older Node versions.
   return new Promise<Error | string>((res, reject) => {
-    readFile(path, 'utf8', (err, data) => {
-      if (err) {
-        reject(err);
-      } else {
-        res(data);
-      }
+    // tslint:disable-next-line:no-unsafe-any
+    fsLimiter.push((done: () => void) => {
+      readFile(path, 'utf8', (err, data) => {
+        done();
+
+        if (err) {
+          reject(err);
+        } else {
+          res(data);
+        }
+      });
     });
   });
 }

packages/utils/test/object.test.ts

@@ -1,4 +1,4 @@
-import { clone, deserialize, fill, serialize, safeNormalize, urlEncode } from '../src/object';
+import { clone, deserialize, fill, safeNormalize, serialize, urlEncode } from '../src/object';
 
 const MATRIX = [
   { name: 'boolean', object: true, serialized: 'true' },