Skip to content

Commit 51577b8

Browse files
committed
add links to comment
1 parent c92b3eb commit 51577b8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/utils/src/object.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,11 @@ function getWalkSource(
108108
[key: string]: any;
109109
} = {};
110110

111+
// Accessing event attributes can throw (see https://github.com/getsentry/sentry-javascript/issues/768 and
112+
// https://github.com/getsentry/sentry-javascript/issues/838), but accessing `type` hasn't been wrapped in a
113+
// try-catch in at least two years and no one's complained, so that's likely not an issue anymore
111114
source.type = event.type;
112115

113-
// Accessing event.target can throw (see getsentry/raven-js#838, #768)
114116
try {
115117
source.target = isElement(event.target)
116118
? htmlTreeAsString(event.target)

0 commit comments

Comments
 (0)