Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP KMS: Support the option.WithTokenSource() for the GCP KMS client, similar to kms.CredentialsProvider and azkv.TokenCredential #1792

Open
matheuscscp opened this issue Mar 10, 2025 · 0 comments · May be fixed by #1794

Comments

@matheuscscp
Copy link

matheuscscp commented Mar 10, 2025

First of all, thank you so very much for SOPS! In my opinion it powers a very critical component of GitOps. I'm a Flux core maintainer so you can guess how much I love GitOps and consequently how much I also love SOPS :)

Now, on to the feature request :)

As a user I'd like the ability to use multi-tenant workload identity for decrypting SOPS-encrypted secrets in CNCF Flux through the Kustomization API using GCP KMS. How I'm planning to do it on the Flux side is detailed in this section of the RFC for Multi-Tenant Workload Identity (RFC link).

In order to enable this use case it is necessary to implement an interface for GCP KMS similar to the interfaces for AWS and Azure kms.CredentialsProvider and azkv.TokenCredential. The equivalent interface for GCP would be oauth2.TokenSource. There are a number of ways how one could create an object that implements this interface, so this would definitely be very helpful for users of the GCP SOPS SDK, and hence would enable more advanced methods of GCP KMS authentication to be used for SOPS.

I'm more than willing to contribute this feature, my plan is to open a PR next weekend, please consider reviewing it! 🙏 🙏 🙏

Edit: PR opened sooner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants