Skip to content

Commit 7b4a197

Browse files
authored
Improve logging when there is no validator found for a path (#40)
1 parent 79450cc commit 7b4a197

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

openapi-validation-core/src/main/java/com/getyourguide/openapi/validation/core/validator/MultipleSpecOpenApiInteractionValidatorWrapper.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import org.apache.commons.lang3.tuple.Pair;
1313

1414
public class MultipleSpecOpenApiInteractionValidatorWrapper implements OpenApiInteractionValidatorWrapper {
15-
public static final String MESSAGE_KEY_VALIDATOR_FOUND = "zopenapi-validator-java.noValidatorFound";
15+
public static final String MESSAGE_KEY_NO_VALIDATOR_FOUND = "openapi-validator-java.noValidatorFound";
1616
private final List<Pair<Pattern, OpenApiInteractionValidatorWrapper>> validators;
1717

1818
public MultipleSpecOpenApiInteractionValidatorWrapper(
@@ -49,8 +49,8 @@ private Optional<OpenApiInteractionValidatorWrapper> getValidatorForPath(String
4949

5050
private static SimpleMessage buildNoValidatorFoundMessage(String path) {
5151
return new SimpleMessage(
52-
MESSAGE_KEY_VALIDATOR_FOUND,
53-
"No validator found for path: " + path,
52+
MESSAGE_KEY_NO_VALIDATOR_FOUND,
53+
"ValidatorConfiguration has no spec file matching path: " + path,
5454
ValidationReport.Level.WARN
5555
);
5656
}

openapi-validation-core/src/test/java/com/getyourguide/openapi/validation/core/validator/MultipleSpecOpenApiInteractionValidatorWrapperTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.getyourguide.openapi.validation.core.validator;
22

3-
import static com.getyourguide.openapi.validation.core.validator.MultipleSpecOpenApiInteractionValidatorWrapper.MESSAGE_KEY_VALIDATOR_FOUND;
3+
import static com.getyourguide.openapi.validation.core.validator.MultipleSpecOpenApiInteractionValidatorWrapper.MESSAGE_KEY_NO_VALIDATOR_FOUND;
44
import static org.junit.jupiter.api.Assertions.assertEquals;
55
import static org.mockito.ArgumentMatchers.any;
66
import static org.mockito.Mockito.mock;
@@ -52,8 +52,8 @@ public void testReturnsViolationWhenNoMatchingValidatorFound() {
5252
var messages = report.getMessages();
5353
assertEquals(1, messages.size());
5454
var message = messages.get(0);
55-
assertEquals(MESSAGE_KEY_VALIDATOR_FOUND, message.getKey());
56-
assertEquals("No validator found for path: /123", message.getMessage());
55+
assertEquals(MESSAGE_KEY_NO_VALIDATOR_FOUND, message.getKey());
56+
assertEquals("ValidatorConfiguration has no spec file matching path: /123", message.getMessage());
5757
}
5858

5959
private static MockValidatorResult mockValidator() {

0 commit comments

Comments
 (0)