Merge fix for various warnings

Fixes -Wdelete-non-abstract-non-virtual-dtor, -Wreorder and deprecation warnings.

Related PR: #1076

Author: upsj

include/ginkgo/core/base/executor.hpp

@@ -1480,8 +1480,8 @@ class CudaExecutor : public detail::ExecutorBase<CudaExecutor>,
                  bool device_reset = false,
                  allocation_mode alloc_mode = default_cuda_alloc_mode)
         : EnableDeviceReset{device_reset},
-          alloc_mode_{alloc_mode},
-          master_(master)
+          master_(master),
+          alloc_mode_{alloc_mode}
     {
         this->get_exec_info().device_id = device_id;
         this->get_exec_info().num_computing_units = 0;
@@ -1685,8 +1685,8 @@ class HipExecutor : public detail::ExecutorBase<HipExecutor>,
                 bool device_reset = false,
                 allocation_mode alloc_mode = default_hip_alloc_mode)
         : EnableDeviceReset{device_reset},
-          alloc_mode_(alloc_mode),
-          master_(master)
+          master_(master),
+          alloc_mode_(alloc_mode)
     {
         this->get_exec_info().device_id = device_id;
         this->get_exec_info().num_computing_units = 0;

include/ginkgo/core/log/logger.hpp

@@ -531,6 +531,8 @@ public:                                                              \
     static constexpr mask_type criterion_events_mask =
         criterion_check_started_mask | criterion_check_completed_mask;
 
+    virtual ~Logger() = default;
+
 protected:
     /**
      * Constructor for a Logger object.

include/ginkgo/core/matrix/csr.hpp

@@ -186,6 +186,8 @@ class Csr : public EnableLinOp<Csr<ValueType, IndexType>>,
          */
         strategy_type(std::string name) : name_(name) {}
 
+        virtual ~strategy_type() = default;
+
         /**
          * Returns the name of strategy
          *

include/ginkgo/core/stop/residual_norm.hpp

@@ -98,8 +98,8 @@ class ResidualNormBase
                               remove_complex<ValueType> reduction_factor,
                               mode baseline)
         : EnablePolymorphicObject<ResidualNormBase, Criterion>(exec),
-          device_storage_{exec, 2},
           reduction_factor_{reduction_factor},
+          device_storage_{exec, 2},
           baseline_{baseline},
           system_matrix_{args.system_matrix},
           b_{args.b},

test/test_install/test_install.cpp

@@ -328,7 +328,7 @@ int main()
 
     // core/log/convergence.hpp
     {
-        auto test = gko::log::Convergence<>::create(exec);
+        auto test = gko::log::Convergence<>::create();
     }
 
     // core/log/record.hpp
@@ -338,13 +338,13 @@ int main()
 
     // core/log/stream.hpp
     {
-        auto test = gko::log::Stream<>::create(exec);
+        auto test = gko::log::Stream<>::create();
     }
 
 #if GKO_HAVE_PAPI_SDE
     // core/log/papi.hpp
     {
-        auto test = gko::log::Papi<>::create(exec);
+        auto test = gko::log::Papi<>::create();
     }
 #endif  // GKO_HAVE_PAPI_SDE