|
| 1 | +# Node.js Diagnostics WorkGroup Meeting 2020-10-28 |
| 2 | + |
| 3 | +## Links |
| 4 | + |
| 5 | +* **Recording**: https://www.youtube.com/watch?v=kjgGc1_KcuQ |
| 6 | +* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/438 |
| 7 | +* **Minutes Google Doc**: https://docs.google.com/document/d/1-rm5JJxdq9Muwd4oqufhE6gP4xyu0Ob8g7Fc_FcLUyA/edit |
| 8 | + |
| 9 | +## Present |
| 10 | + |
| 11 | +* Diagnostics team: @nodejs/diagnostics |
| 12 | +* Stephen Belanger (@qard) |
| 13 | +* Rafael Gonzaga (@rafaelgss) |
| 14 | +* Michael Dawson (@mhdawson) |
| 15 | +* Chengzhong Wu (@legendecas) |
| 16 | +* Gireesh Punathil (@gireeshpunathil) |
| 17 | + |
| 18 | + |
| 19 | +## Agenda |
| 20 | + |
| 21 | +## Announcements |
| 22 | + |
| 23 | +*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. |
| 24 | + |
| 25 | +### nodejs/node |
| 26 | + |
| 27 | +* lib: add span API to diagnostics_channel [#35534](https://github.com/nodejs/node/pull/35534) |
| 28 | + * Waiting on diagnostics channel to land first |
| 29 | + |
| 30 | +* lib: make diagnostics_channel async iterable [#35532](https://github.com/nodejs/node/pull/35532) |
| 31 | + * Waiting on diagnostics channel to land first |
| 32 | + |
| 33 | +* Proposal: mark AsyncResource and AsyncLocalStorage as stable [#35286](https://github.com/nodejs/node/issues/35286) |
| 34 | + * Seems like there is consensus that AsyncResource should be able to become stable |
| 35 | + * For AsyncLocalStorage, we need to come up/agree exit criteria. Gireesh pasted in |
| 36 | + Starting point for exit criteria based on previous features that went experimental->stable |
| 37 | + https://github.com/nodejs/node/issues/35286#issuecomment-708899145 |
| 38 | + |
| 39 | +* lib: create diagnostics_channel module [#34895](https://github.com/nodejs/node/pull/34895) |
| 40 | + * Waiting on reviews, needs more TSC approvals |
| 41 | + |
| 42 | +* Node.js' internal scripts should be hidden in the inspector. [#11893](https://github.com/nodejs/node/issues/11893) |
| 43 | + * wait until we have Mary who might have a better insight |
| 44 | + |
| 45 | +### nodejs/diagnostics |
| 46 | + |
| 47 | +* Identify async_hooks use cases beyond AsyncLocalStorage [#437](https://github.com/nodejs/diagnostics/issues/437) |
| 48 | + * Good start on getting some feedback/capture the use case |
| 49 | + |
| 50 | +* Add ioredis to problematic-modules.md [#430](https://github.com/nodejs/diagnostics/pull/430) |
| 51 | + * Just waiting on replacement issues to be opened. |
| 52 | + |
| 53 | +* Node CPU Profiling Roadmap [#148](https://github.com/nodejs/diagnostics/issues/148) |
| 54 | + * skip for this week as Mary is Champion/has context |
| 55 | + |
| 56 | +* \[async_hooks\] stable API - tracking issue [#124](https://github.com/nodejs/diagnostics/issues/124) |
| 57 | + * closed in favor of https://github.com/nodejs/diagnostics/issues/437 |
| 58 | + |
| 59 | + |
| 60 | +## Q&A, Other |
| 61 | + |
| 62 | +## Upcoming Meetings |
| 63 | + |
| 64 | +* **Node.js Foundation Calendar**: https://nodejs.org/calendar |
0 commit comments