Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect permission description for getting remote pull request branch #36778

Closed
1 task done
koyuki7w opened this issue Mar 12, 2025 · 3 comments · Fixed by #36792
Closed
1 task done

Incorrect permission description for getting remote pull request branch #36778

koyuki7w opened this issue Mar 12, 2025 · 3 comments · Fixed by #36792
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review waiting for review Issue/PR is waiting for a writer's review

Comments

@koyuki7w
Copy link
Contributor

koyuki7w commented Mar 12, 2025

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

What part(s) of the article would you like to see updated?

The beginning of the page reads:

Anyone with write access to a repository can pull a remote pull request down locally.

However, it seems that only read permission is needed to fetch remote branches pull/*/head.

Additional information

No response

@koyuki7w koyuki7w added the content This issue or pull request belongs to the Docs Content team label Mar 12, 2025
Copy link

welcome bot commented Mar 12, 2025

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 12, 2025
@subatoi subatoi added waiting for review Issue/PR is waiting for a writer's review more-information-needed More information is needed to complete review and removed triage Do not begin working on this issue until triaged by the team labels Mar 12, 2025
@subatoi
Copy link
Contributor

subatoi commented Mar 12, 2025

@koyuki7w Thanks for spotting that and raising an issue

We think the best solution here is actually to delete that line altogether. Would you like to raise a pull request to do that yourself?

https://github.com/github/docs-internal/blob/main/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally.md?plain=1#L9

@koyuki7w
Copy link
Contributor Author

@subatoi Thanks. I've opened the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants