-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abortcontroller-polyfill eventing isn't implemented properly #800
Comments
NOTE: This issue was reported last year to the |
LGTM. |
JakeChampion
added a commit
that referenced
this issue
Jul 30, 2020
cr313
added a commit
to cr313/fetch-Js-flow
that referenced
this issue
Apr 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I needed an AbortSignal/AbortController polyfill for work on RxJS, and I found out that the event dispatching in
abortcontroll-polyfill
(the recommended abort mechanism for this library) was not properly synchronous and didn't implement behaviors as they would actually exist in the wild. This is actually a big deal, as abort/cancellation should happen synchronously whenabort()
is called on the abort controller, and the order of events there is very important.To that end, I started down the road of creating a PR for
abortcontroller-polyfill
, but: 1) I was almost rewriting the entire thing. and 2) That repository seemed to be somewhat stagnant and I needed a properly implemented one ASAP.So I've created a new package called yet-another-abortcontroller-polyfill that aims to be accurate as possible when it comes to the semantics of the type and the events around it.
The problem I see is this is the defacto fetch polyfill, and if it has people polyfilling and using poorly implemented AbortSignals, it is going to break other things (like RxJS) in hard-to-explain ways for other users.
So I'd like to reconcile this somehow.
The text was updated successfully, but these errors were encountered: