Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank line before list is not handled the way Github preview handles them (Markdown) #386

Closed
mdio opened this issue Oct 23, 2014 · 2 comments

Comments

@mdio
Copy link

mdio commented Oct 23, 2014

Assuming a test.md with the following content:

My headline
============

This is a list:
 - Point 1
 - Point 2
 - Point 3
     - Point 3.1
     - Point 3.2
 - Point 4

When running github-markup test.md I get the following output:

My headline

This is a list: - Point 1 - Point 2 - Point 3 - Point 3.1 - Point 3.2 - Point 4

Github displays it as:

My headline

This is a list:

  • Point 1
  • Point 2
  • Point 3
    • Point 3.1
    • Point 3.2
  • Point 4

I would assume that this tool is used to generate those previews and the output to be the same.

I'm on Mac OS X 10.9 with github-markup 1.3.0 and the fix proposed in #385 as I ran into the same error.

@mdio mdio changed the title Blank line before list is not handled the way Github preview handles them Blank line before list is not handled the way Github preview handles them (Markdown) Oct 23, 2014
@bkeepers
Copy link
Contributor

bkeepers commented Nov 3, 2014

If you add the github-markdown gem to you project, then you should get the same rendering as GitHub. Let me know if that doesn't work.

@bkeepers bkeepers closed this as completed Nov 3, 2014
@mdio
Copy link
Author

mdio commented Nov 4, 2014

That did the trick. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants