Refactor: Centralized Harbor Error Parsing for all commands #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a cleaner, more reliable, and consistent approach to error handling across the Harbor CLI. It standardizes parsing and reporting API errors, making the CLI more user-friendly and developer-maintainable.
Key Changes
Added
ParseHarborError
utilityPayload
from Harbor API responses."user not found field"
"permission denied field"
)Replaced
Run
withRunE
across commandsParseHarborError
function for consistent logging.Code cleanup and simplification
Motivation
Error Output Before vs After
Before:
After:
Related Issues
Fix #393
Fix #316
Fix #253
Fix #262