Skip to content

project delete should allow only id when --project-id flag is specified #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bupd opened this issue Apr 22, 2025 · 2 comments · May be fixed by #424
Open

project delete should allow only id when --project-id flag is specified #436

bupd opened this issue Apr 22, 2025 · 2 comments · May be fixed by #424
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bupd
Copy link
Collaborator

bupd commented Apr 22, 2025

Description

  • project delete cmd with --project-id should not allow multiple args.
  • project delete cmd with --project-id should not allow string as input
❯ ./bin/harbor-dev project delete --project-id 1632 1627 rc_test
INFO Project 1632 deleted successfully

Expected Behaviour

❯ ./bin/harbor-dev project delete --project-id 1632 1627 rc_test
Error: Expected only one argument.
@bupd bupd self-assigned this Apr 22, 2025
@bupd bupd added the bug Something isn't working label Apr 22, 2025
@bupd bupd removed their assignment Apr 22, 2025
@bupd bupd changed the title project delete should allow only id project delete should allow only id when --project-id flag is specified Apr 22, 2025
@bupd bupd added the good first issue Good for newcomers label Apr 22, 2025
@meethereum
Copy link
Contributor

Image

similar is the case when invalid project ID is used. I believe work is being done on centralised error handling ? So should I go ahead with changing the error messages or wait for that centralised error handling to be completed? I believe we are going to get a lot of issues like this

@rizul2108
Copy link
Collaborator

Yeah I will handle this in already open PR #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants