Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to remove reference to deprecated module 'github.com/golang/protobuf' #312

Open
abhithmv opened this issue May 25, 2023 · 5 comments

Comments

@abhithmv
Copy link

Hi,
appengine has a reference to deprecated module 'github.com/golang/protobuf'. Because of which our consuming module depends indirectly on deprecated module.
Is it possible to remove the deprecated module and release a new version of appengine?
Thanks.

@trakhimenok
Copy link
Contributor

Is this a duplicate of #228?

@UnitedMarsupials
Copy link

Is this a duplicate of #228

No, it is not. The #228 added the new version of protobuf.

This ticket seeks to remove the obsolete version. Currently both versions are listed as dependencies... Maybe, #228 should have requested a replacement, but it did not...

@trakhimenok
Copy link
Contributor

No, it is not. The #228 added the new version of protobuf.

This ticket seeks to remove the obsolete version. Currently both versions are listed as dependencies... Maybe, #228 should have requested a replacement, but it did not...

#228 does not add anything as it's not a PR but an issue.

The #228 propose the switch from obsolete to current version:

Image

So I believe this one a duplicate. Anyway it looks like nobody care anyway :(

@UnitedMarsupials
Copy link

So I believe this one a duplicate.

The #228 added use of the new protobuf, without deleting the old one... This ticket requested the removal of all uses of the old protobuf. Whether this is a duplication is a matter of semantics, I suppose...

Anyway it looks like nobody care anyway :(

The #346 is a merge-request which provided the necessary changes. Those have one conflict now, and I created my own fork to address it.

However, I don't know, how to make it known without obsoleting the #346 -- and claiming the credit, that duly belongs there...

@trakhimenok
Copy link
Contributor

Good work but I would not hold my breath getting it merged anytime soon. This is saga is 4 years old now at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants