Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Commit 681e6f5

Browse files
committedOct 2, 2017
internal/gps: fix case mismatch error with multiple dependers
Previously, errors like the following could occur: v0.4.2: Could not introduce github.com/sirupsen/logrus due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/evalphobia/[email protected]" was already established as the case variant for that project root by the following other dependers: (root) github.com/docker/docker@8510adf8c856d6f0871650216a0e1d7e6ece46ee This fix matches the correct behavior when there is only one depender earlier in the function.
1 parent ac1a162 commit 681e6f5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎internal/gps/solve_failures.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func (e *caseMismatchFailure) Error() string {
8484
var buf bytes.Buffer
8585

8686
str := "Could not introduce %s due to a case-only variation: it depends on %q, but %q was already established as the case variant for that project root by the following other dependers:\n"
87-
fmt.Fprintf(&buf, str, e.goal.dep.Ident.ProjectRoot, e.current, a2vs(e.goal.depender))
87+
fmt.Fprintf(&buf, str, a2vs(e.goal.depender), e.goal.dep.Ident.ProjectRoot, e.current)
8888

8989
for _, c := range e.failsib {
9090
fmt.Fprintf(&buf, "\t%s\n", a2vs(c.depender))

0 commit comments

Comments
 (0)
This repository has been archived.