status: Handle code climate suggestion re: errs

akutz · akutz · commit 85d23faca92d · 2018-03-28T06:57:02.000-05:00
This patch updates two lines to return errors directly as recommended by
the CI tool, code climate.
diff --git a/cmd/dep/status.go b/cmd/dep/status.go
@@ -1209,11 +1209,7 @@ func basicOutputAll(out outputter, slp []gps.LockedProject, bsMap map[string]*Ba
 		}
 	}
 
-	if footerErr := out.BasicFooter(); footerErr != nil {
-		return footerErr
-	}
-
-	return nil
+	return out.BasicFooter()
 }
 
 // detailOutputAll takes an outputter, a project list, and a map of ProjectRoot to *DetailStatus and
@@ -1231,11 +1227,7 @@ func detailOutputAll(out outputter, slp []gps.LockedProject, dsMap map[string]*D
 		}
 	}
 
-	if footerErr := out.DetailFooter(metadata); footerErr != nil {
-		return footerErr
-	}
-
-	return nil
+	return out.DetailFooter(metadata)
 }
 
 func formatVersion(v gps.Version) string {

Original file line number	Diff line number	Diff line change
`@@ -1209,11 +1209,7 @@ func basicOutputAll(out outputter, slp []gps.LockedProject, bsMap map[string]*Ba`
`1209`	`1209`	`}`
`1210`	`1210`	`}`
`1211`	`1211`
`1212`		`- if footerErr := out.BasicFooter(); footerErr != nil {`
`1213`		`- return footerErr`
`1214`		`- }`
`1215`		`-`
`1216`		`- return nil`
	`1212`	`+ return out.BasicFooter()`
`1217`	`1213`	`}`
`1218`	`1214`
`1219`	`1215`	`// detailOutputAll takes an outputter, a project list, and a map of ProjectRoot to *DetailStatus and`
`@@ -1231,11 +1227,7 @@ func detailOutputAll(out outputter, slp []gps.LockedProject, dsMap map[string]*D`
`1231`	`1227`	`}`
`1232`	`1228`	`}`
`1233`	`1229`
`1234`		`- if footerErr := out.DetailFooter(metadata); footerErr != nil {`
`1235`		`- return footerErr`
`1236`		`- }`
`1237`		`-`
`1238`		`- return nil`
	`1230`	`+ return out.DetailFooter(metadata)`
`1239`	`1231`	`}`
`1240`	`1232`
`1241`	`1233`	`func formatVersion(v gps.Version) string {`