Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

dep ensure -n isn't actually a no-op #145

Closed
pbennett opened this issue Jan 25, 2017 · 4 comments · Fixed by #256
Closed

dep ensure -n isn't actually a no-op #145

pbennett opened this issue Jan 25, 2017 · 4 comments · Fixed by #256

Comments

@pbennett
Copy link

pbennett commented Jan 25, 2017

Go 1.8 rc1 / osx
ensure -n is documented as a dry-run, but still does all the work, populating the vendor folder if it's not already there.
With no vendor/ directory present:

dep init
dep ensure -n
vendor/ is created as if -n was never specified.
Since there is no output normally, I'm assuming this is meant to be used alongside with the -v option.
(as of commit 1b193f4)

@rakyll
Copy link
Contributor

rakyll commented Jan 26, 2017

To be clear, -n is doing nothing right. This needs to be implemented for ensure and remove.

@pbennett
Copy link
Author

Correct, -n is basically being ignored and it's still running everything normally.

@carolynvs
Copy link
Collaborator

Is this a good candidate for me to pick up and take a crack at?

@sdboyer
Copy link
Member

sdboyer commented Feb 21, 2017

@carolynvs yeah, I think this should be a good one to pick up. Might be as simple as a single if statement :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants