Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Prune files based on known unused build constraints #1511

Closed
lindner opened this issue Jan 8, 2018 · 1 comment
Closed

Prune files based on known unused build constraints #1511

lindner opened this issue Jan 8, 2018 · 1 comment

Comments

@lindner
Copy link

lindner commented Jan 8, 2018

It would be valuable if a project could specify that they are not using a specific build extension, which would allow for pruning more dependencies.

For example in Perkeep we import go-oauth

  vendor/golang.org/x/oauth2/google/appengine_hook.go:
  // +build appengine appenginevm".

Which pulls in the full appengine dep

We would like to specify that we are not compatible with appenginevm and omit files and dependencies for those.

@sdboyer
Copy link
Member

sdboyer commented Jan 26, 2018

This actually gets really tricky to do, unfortunately - see #291.

i agree there's value to doing it, but it still seems like it's in the "nice to have" category - especially given that you can use ignored to achieve much the same effect.

(closing as dup of #291, which would necessarily cover this)

@sdboyer sdboyer closed this as completed Jan 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants