Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Add table tests for importers #824

Closed
carolynvs opened this issue Jul 15, 2017 · 2 comments · Fixed by #897
Closed

Add table tests for importers #824

carolynvs opened this issue Jul 15, 2017 · 2 comments · Fixed by #897

Comments

@carolynvs
Copy link
Collaborator

It would help when maintaining importers to have their tests operate on the same testdata. Each row in the table would be the tool's config (e.g. glide.yaml/lock), but the output for each will be the same Gopkg.toml/lock. If a tool has edge cases beyond the "lowest common denominator" between the tools, then it should be validated in a separate unit test.

For example, the test cases for glide and godep are very sim liar but have slight changes

@sebdah
Copy link
Contributor

sebdah commented Jul 25, 2017

FYI, I've started looking at this. Will submit a WIP PR in the next day or so to confirm that my approach is ✅.

@sebdah
Copy link
Contributor

sebdah commented Jul 26, 2017

Have added the above referenced PR to introduce table based tests for the godep and glide importers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants