Skip to content

Commit 5bf9249

Browse files
committed
net/http: enable segfaulting test on darwin/arm
Issue #10043 was resolved by https://golang.org/cl/7072. This test now passes. Change-Id: I7bdef63d9ee4edcede23613a14a2ddce14018f34 Reviewed-on: https://go-review.googlesource.com/7931 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 14082fa commit 5bf9249

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/net/http/transport_test.go

-7
Original file line numberDiff line numberDiff line change
@@ -1788,13 +1788,6 @@ var proxyFromEnvTests = []proxyFromEnvTest{
17881788
}
17891789

17901790
func TestProxyFromEnvironment(t *testing.T) {
1791-
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm" {
1792-
// fmt.Sprintf("%v", (*URL)(nil)) causes a segfault inside the string
1793-
// method, which lldb intercepts on the darwin/arm builder. Until it
1794-
// is fixed, skipping the test.
1795-
t.Skipf("skipping on %s/%s, issue 10043", runtime.GOOS, runtime.GOARCH)
1796-
}
1797-
17981791
ResetProxyEnv()
17991792
for _, tt := range proxyFromEnvTests {
18001793
os.Setenv("HTTP_PROXY", tt.env)

0 commit comments

Comments
 (0)