Skip to content

Commit 9270973

Browse files
committedJan 18, 2016
runtime: don't run TestEnsureDropM on windows or plan9
This is testing code in asm_GOARCH.s, so it's not necessary to run the test on systems where it doesn't build. Fixes #13991. Change-Id: Ia7a2d3a34b32e6987dc67428c1e09e63baf0518a Reviewed-on: https://go-review.googlesource.com/18707 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 01b8640 commit 9270973

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed
 

‎src/runtime/crash_cgo_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,10 @@ func TestCgoExecSignalMask(t *testing.T) {
137137

138138
func TestEnsureDropM(t *testing.T) {
139139
// Test for issue 13881.
140+
switch runtime.GOOS {
141+
case "windows", "plan9":
142+
t.Skipf("skipping dropm test on %s", runtime.GOOS)
143+
}
140144
got := runTestProg(t, "testprogcgo", "EnsureDropM")
141145
want := "OK\n"
142146
if got != want {

‎src/runtime/testdata/testprogcgo/dropm.go

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5+
// +build !plan9,!windows
6+
57
// Test that a sequence of callbacks from C to Go get the same m.
68
// This failed to be true on arm and arm64, which was the root cause
79
// of issue 13881.

0 commit comments

Comments
 (0)
Please sign in to comment.