Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: missing locking in certain Tx calls [Go 1.9] #22314

Closed
rsc opened this issue Oct 18, 2017 · 3 comments
Closed

database/sql: missing locking in certain Tx calls [Go 1.9] #22314

rsc opened this issue Oct 18, 2017 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.9.2

Comments

@rsc
Copy link
Contributor

rsc commented Oct 18, 2017

Limited form of #21117.
@rsc rsc added this to the Go1.9.2 milestone Oct 18, 2017
@rsc
Copy link
Contributor Author

rsc commented Oct 18, 2017

CL 65731 OK for Go 1.9.2.
At least tentatively. Leaving #21117 in the Go 1.9.2 milestone as a reminder to evaluate this.
But I'd like to prepare a toolchain with the fix to see if anyone with problems is helped.

@rsc rsc added the CherryPickApproved Used during the release process for point releases label Oct 18, 2017
This was referenced Oct 18, 2017
Closed
Closed
@rsc
Copy link
Contributor Author

rsc commented Oct 19, 2017

Per #21117 (comment), CL 65731 fixes some very common crashes observed in the wild, and while I do think it's incomplete I also think it's clearly safe, so let's keep it for Go 1.9.2.

@rsc
Copy link
Contributor Author

rsc commented Oct 26, 2017

go1.9.2 has been packaged and includes:

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Oct 26 21:09:25 UTC

@rsc rsc closed this as completed Oct 26, 2017
@ivanich ivanich mentioned this issue Oct 31, 2017
Closed
@golang golang locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.9.2
Development

No branches or pull requests
2 participants
@rsc @gopherbot