-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc/swig/stdio: test fails on windows #7281
Labels
Milestone
Comments
I think that when issue #7156 is fixed this will most likely be fixed as well. |
I've found some useful resources. There is an issue in SWIG for the Go language on Windows: "Go: SWIG doesn't work on Windows" swig/swig#100 It includes links to a topic on golang-nuts with a patch that fixes the problem in SWIG: https://groups.google.com/d/msg/golang-nuts/9L0U4Q7AtyE/iNFTnLJH9xMJ The libtorrent library uses an another approach to fix the problem, it modifies the generated .cxx and .c files: https://github.com/steeve/libtorrent-go/blob/master/Makefile#L124 |
Ian, you were just in there. Have you seen the patch at https://groups.google.com/forum/#!msg/golang-nuts/9L0U4Q7AtyE/iNFTnLJH9xMJ ? Is it worth applying to SWIG? Owner changed to @ianlancetaylor. |
It's a very invasive patch and does several things in what I think is the wrong way. E.g., there should be no need to have a -windows option at all; SWIG should do the right thing automatically. The right approach is the cmd/go CL you approved that will land in 1.3 if nobody objects, and getting Windows external linking to work. If we do those things, the patch you cite is both unnecessary and incorrect. |
Now that #7156 has been fixed 7 months ago, could someone verify whether this is fixed too? |
env
E:\Go\misc\swig>go test -x -v -work ./stdio
|
This should be fixed, now that #4069 is fixed. This time for sure. Anybody want to try it out? You will need SWIG 3.0.6 or later. |
@ianlancetaylor The test is OK on win7/64bit. |
Thanks for checking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by czarek.tomczak:
Attachments:
The text was updated successfully, but these errors were encountered: