Skip to content

Commit 85b6527

Browse files
committed
gopls/internal/test: temporarily disable staticcheck with gotypesalias=1
staticcheck will need work to accommodate gotypesalias=1. In the meantime we disable this test in that mode; we plan to reenable it before the next gopls release. Updates golang/go#65294 Change-Id: I857edb758f83f180a4d92b7100e99c3401b1d957 Reviewed-on: https://go-review.googlesource.com/c/tools/+/575698 Reviewed-by: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 118b98b commit 85b6527

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

gopls/internal/test/integration/misc/staticcheck_test.go

+13
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
package misc
66

77
import (
8+
"os"
9+
"strings"
810
"testing"
911

1012
"golang.org/x/tools/internal/testenv"
@@ -15,6 +17,11 @@ import (
1517
func TestStaticcheckGenerics(t *testing.T) {
1618
testenv.NeedsGo1Point(t, 20) // staticcheck requires go1.20+
1719

20+
// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
21+
if strings.Contains(os.Getenv("GODEBUG"), "gotypesalias=1") {
22+
t.Skipf("staticcheck needs updates for materialized aliases")
23+
}
24+
1825
const files = `
1926
-- go.mod --
2027
module mod.com
@@ -79,6 +86,12 @@ var FooErr error = errors.New("foo")
7986
// analysis.RelatedInformation.End is not set.
8087
func TestStaticcheckRelatedInfo(t *testing.T) {
8188
testenv.NeedsGo1Point(t, 20) // staticcheck is only supported at Go 1.20+
89+
90+
// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
91+
if strings.Contains(os.Getenv("GODEBUG"), "gotypesalias=1") {
92+
t.Skipf("staticcheck needs updates for materialized aliases")
93+
}
94+
8295
const files = `
8396
-- go.mod --
8497
module mod.test

0 commit comments

Comments
 (0)