Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error, unexpected '}' in some examples #32

Closed
ebotey opened this issue Apr 9, 2014 · 4 comments
Closed

Syntax error, unexpected '}' in some examples #32

ebotey opened this issue Apr 9, 2014 · 4 comments
Assignees

Comments

@ebotey
Copy link

ebotey commented Apr 9, 2014

Hi,
Executing the next script:

find . -iregex '.*(.php)' -exec php -l '{}' ; | grep "Parse error:"

you can see that 3 examples files has syntax errors.

Parse error: syntax error, unexpected '}', expecting T_CATCH in ./googleads-php-lib/examples/Dfp/v201403/CreativeSetService/CreateCreativeSetsExample.php on line 75
Parse error: syntax error, unexpected '}', expecting T_CATCH in ./googleads-php-lib/examples/Dfp/v201403/InventoryService/CreateMobileAdUnitExample.php on line 87
Parse error: syntax error, unexpected '}', expecting T_CATCH in ./googleads-php-lib/examples/Dfp/v201403/InventoryService/CreateVideoAdUnitExample.php on line 101

I've downloaded via composer the 5.2.2 version of googleads-php-lib and we use php 5.3.27.

Lluis

@vtsao vtsao self-assigned this Apr 9, 2014
@vtsao
Copy link
Contributor

vtsao commented Apr 9, 2014

Thanks good catch, will fix this for the next release.

@saturnism
Copy link
Contributor

@vtsao we can enhance the release script to check for these.

@jxn
Copy link

jxn commented Apr 9, 2014

php -l is a good start

@vtsao
Copy link
Contributor

vtsao commented Apr 11, 2014

Fixed in 5.2.3.

@vtsao vtsao closed this as completed Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants