New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of return value of empty as a function parameter in CurlUtils for PHP users using a PHP version < 5.5. #74

Closed

vtsao opened this issue Dec 11, 2014 · 2 comments

Assignees

Contributor

vtsao commented Dec 11, 2014

Fix usage of return value of empty as a function parameter in CurlUtils for PHP users using a PHP version < 5.5.
https://github.com/googleads/googleads-php-lib/blob/master/src/Google/Api/Ads/Common/Util/CurlUtils.php#L56

Offending line:
$this->SetOpt($ch, CURLOPT_FOLLOWLOCATION, empty(ini_get('open_basedir')));

vtsao self-assigned this

Contributor Author

vtsao commented Dec 11, 2014

Will be fixed in the next release.

Contributor Author

vtsao commented Dec 11, 2014

Fixed in 5.7.1.

vtsao closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment