Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP doc comments type is "the" #96

Closed
EliyahuFisherman opened this issue Sep 17, 2015 · 3 comments
Closed

PHP doc comments type is "the" #96

EliyahuFisherman opened this issue Sep 17, 2015 · 3 comments
Assignees
Labels

Comments

@EliyahuFisherman
Copy link

I'm using phpstorm IDE since the type in the php doc is "the" for some arguments, the editor is complains for example:
$reportService = $user->GetService('ReportService', 'v201508');
the editor warns that 'reportService' is a string & should be "the"

@vtsao vtsao self-assigned this Sep 17, 2015
@vtsao vtsao added the bug label Sep 17, 2015
@vtsao
Copy link
Contributor

vtsao commented Sep 17, 2015

Thanks for reporting this, I'll make sure the PHPDoc is fixed.

@hakimio
Copy link

hakimio commented Oct 30, 2015

v6.4.0 release notes state that this bug was fixed but there are still loads of "@return the something" in the source...

@vtsao
Copy link
Contributor

vtsao commented Oct 30, 2015

This issue was specifically for GetService, which was fixed in:
https://github.com/googleads/googleads-php-lib/releases/tag/6.4.0

as you mentioned. I filed #100 to go through and fix other occurrences of this.

@vtsao vtsao closed this as completed Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants