Skip to content

Reconcile MakeAuthOptions and PopulateAuthOptions #15089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scotthart opened this issue Apr 15, 2025 · 0 comments
Open

Reconcile MakeAuthOptions and PopulateAuthOptions #15089

scotthart opened this issue Apr 15, 2025 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

These functions are used in separate places and appear to have similar intent, but while PopulateAuthOptions preserves the existing options its given, MakeAuthOptions discards them. This seems incorrect on the surface, but there may be reasons why it behaves this way. Further investigation is needed to determine if MakeAuthOptions can be changed to preserve the options passed in and/or the two functions could be merged.
@scotthart scotthart added the type: cleanup An internal cleanup or hygiene concern. label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scotthart