Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove setup.cfg configuration for creating universal wheels #1175

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 14, 2025

setup.cfg contains a setting to create a Universal Wheel which is only needed if libraries support both Python 2 and Python 3. This library only supports Python 3 so this setting is no longer needed. See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels.

See similar PR googleapis/google-cloud-python#13659 which includes this stack trace

      running bdist_wheel
      /tmp/pip-build-env-9o_3w17v/overlay/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
      !!
      
              ********************************************************************************
              With Python 2.7 end-of-life, support for building universal wheels
              (i.e., wheels that support both Python 2 and Python 3)
              is being obviated.
              Please discontinue using this option, or if you still need it,
              file an issue with pypa/setuptools describing your use case.
      
              By 2025-Aug-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.
              ********************************************************************************
      
      !!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@parthea parthea requested review from a team as code owners March 14, 2025 13:02
@parthea parthea requested a review from leahecole March 14, 2025 13:02
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 14, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Mar 14, 2025
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2025
@chalmerlowe chalmerlowe merged commit dc394ac into main Mar 14, 2025
14 checks passed
@chalmerlowe chalmerlowe deleted the parthea-patch-2 branch March 14, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. automerge Merge the pull request once unit tests and other checks pass. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants