Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support Tuanjie engine (a Unity dialect in China) #722

Open
GarfieldJiang opened this issue Nov 29, 2024 · 2 comments
Open

[FR] Support Tuanjie engine (a Unity dialect in China) #722

GarfieldJiang opened this issue Nov 29, 2024 · 2 comments

Comments

@GarfieldJiang
Copy link

Feature proposal

  • EDM4U Component: Android Resolver, iOS Resolver

For example, Tuanjie engine currently exports and iOS project use Tuanjie-iPhone rather than Unity-iPhone. But the iOS resolver has the constant 'Unity-iPhone' hardcoded, which leads to build failure. I'm not sure whether a similar problem occurs on the Android platform yet.

@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@argzdev argzdev removed the new to be triaged label Nov 29, 2024
@argzdev
Copy link
Collaborator

argzdev commented Feb 18, 2025

Hey @GarfieldJiang, thanks for reaching out. This is interesting. The constant in the codebase is the following:

public const string PROJECT_NAME = "Unity-iPhone";

The fix for this could be to have a conditional checker that changes this constant to Tuanjie-iPhone rather than Unity-iPhone but on top of my head I'm not sure what would be a good solution for this. Probably something like:

public string PROJECT_NAME = GetProjectName();

private static string GetProjectName(){
    if (SystemInfo.deviceModel.Contains("Tuanjie")) {
        return "Tuanjie-iPhone";
    } else {
        return "Unity-iPhone";
    }
}

That said, this is something we haven't explored yet, and maybe something we can consider adding in the future. I've marked this as a feature request for now. While we are unable to promise any timeline for this, we'll definitely keep this under our radar.

P.S. For folks who find this useful, adding an emoji thumbs up on the original post can help us prioritize adding this to the roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants