You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
As the library wraps all dataFetchers in the schema, this means that 'trivial' dataFetchers, ones which do not have actually user-implemented code (fields under an object, usually) are wrapped and no longer marked as 'trivial'. This breaks a lot of tracing and metrics implementations which rely on the trivial marker to ignore dataFetchers which don't have user code.
To Reproduce
Any sort of instrumentation (ie. logging instrumentation for dataFetcher run time) which uses the trivial marker to ignore dataFetchers will no longer work as intended. All fields will be logged unnecessarily.
Describe the bug
As the library wraps all dataFetchers in the schema, this means that 'trivial' dataFetchers, ones which do not have actually user-implemented code (fields under an object, usually) are wrapped and no longer marked as 'trivial'. This breaks a lot of tracing and metrics implementations which rely on the trivial marker to ignore dataFetchers which don't have user code.
To Reproduce
Any sort of instrumentation (ie. logging instrumentation for dataFetcher run time) which uses the trivial marker to ignore dataFetchers will no longer work as intended. All fields will be logged unnecessarily.
The validationSchemaWiring needs to check if the current DF is an instance of TrivialDataFetcher (https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/TrivialDataFetcher.java) and if so the new ValidationDataFetcher must also implement the interface.
The text was updated successfully, but these errors were encountered: